Skip to content

Conversation

@benzekrimaha
Copy link
Contributor

@benzekrimaha benzekrimaha commented Oct 23, 2025

Issue: CLDSRV-724

@codecov
Copy link

codecov bot commented Oct 23, 2025

❌ 14 Tests Failed:

Tests completed Failed Passed Skipped
7583 14 7569 0
View the top 3 failed test(s) by shortest run time
"before each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"::PUT bucket logging With default signature with cross-account target bucket "before each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"
Stack Traces | 0s run time
s3.createBucket is not a function
"before each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"::PUT bucket logging With v4 signature with cross-account target bucket "before each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"
Stack Traces | 0s run time
s3.createBucket is not a function
should allow logging when target bucket is owned by same account::PUT bucket logging With default signature with existing bucket should allow logging when target bucket is owned by same account
Stack Traces | 0s run time
s3.putBucketLogging is not a function
should allow logging when target bucket is owned by same account::PUT bucket logging With v4 signature with existing bucket should allow logging when target bucket is owned by same account
Stack Traces | 0s run time
s3.putBucketLogging is not a function
should return error if pattern is invalid::Invalid regular expression searches should return error if pattern is invalid
Stack Traces | 0.002s run time
done() called multiple times in test <Invalid regular expression searches should return error if pattern is invalid> of file .../test/mdSearch/basicSearch.js; in addition, done() received error: InvalidArgument: Invalid sql where clause sent as search query
    at throwDefaultError (.../cloudserver/cloudserver/node_modules/@.../smithy-client/dist-cjs/index.js:288:22)
    at .../cloudserver/cloudserver/node_modules/@.../smithy-client/dist-cjs/index.js:297:9
    at de_CommandError (.../cloudserver/cloudserver/node_modules/@.../client-s3/dist-cjs/index.js:4868:20)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async .../cloudserver/cloudserver/node_modules/@aws-sdk/client-s3/node_modules/@.../middleware-serde/dist-cjs/index.js:8:24
    at async .../cloudserver/cloudserver/node_modules/@.../middleware-sdk-s3/dist-cjs/index.js:386:20
    at async .../cloudserver/cloudserver/node_modules/@aws-sdk/client-s3/node_modules/@.../middleware-retry/dist-cjs/index.js:254:46
    at async .../cloudserver/cloudserver/node_modules/@.../middleware-sdk-s3/dist-cjs/index.js:63:28
    at async .../cloudserver/cloudserver/node_modules/@.../middleware-sdk-s3/dist-cjs/index.js:90:20
    at async .../cloudserver/cloudserver/node_modules/@aws-sdk/client-s3/node_modules/@.../middleware-logger/dist-cjs/index.js:5:26
    at async makeRequest (.../mdSearch/utils/helpers.js:71:25) {
  '$fault': 'client',
  '$response': [HttpResponse],
  '$retryable': undefined,
  '$metadata': [Object],
  Code: 'InvalidArgument',
  Resource: '',
  RequestId: 'd2e541cd3f4e93b267f4'
}
should show us-east-1 as bucket location sinceIP address endpoint was not in config thereby defaulting to us-east-1::Requests to ip endpoint not in config With default signature should show us-east-1 as bucket location sinceIP address endpoint was not in config thereby defaulting to us-east-1
Stack Traces | 0.002s run time
Expected values to be strictly equal:

undefined !== ''
should show us-east-1 as bucket location sinceIP address endpoint was not in config thereby defaulting to us-east-1::Requests to ip endpoint not in config With v4 signature should show us-east-1 as bucket location sinceIP address endpoint was not in config thereby defaulting to us-east-1
Stack Traces | 0.003s run time
Expected values to be strictly equal:

undefined !== ''
"after each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"::PUT bucket logging With v4 signature with cross-account target bucket "after each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"
Stack Traces | 0.004s run time
The specified bucket does not exist.
"after each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"::PUT bucket logging With default signature with cross-account target bucket "after each" hook for "should return InvalidTargetBucketForLogging when target bucket is owned by different account"
Stack Traces | 0.006s run time
The specified bucket does not exist.
should fail if version id is invalid::PUT object with x-scal-s3-version-id header With v4 signature error handling validation (without cold storage location) should fail if version id is invalid
Stack Traces | 0.016s run time
Expected success got error {"BadRequest":true,"isExpected":true}
+ actual - expected

+ ArsenalError: BadRequest
+     at Object.get (.../lib/errors/index.js:167:31)
+     at RESTClient.endRespond (.../bucketclient/lib/RESTClient.js:329:27)
+     at ClientRequest.<anonymous> (.../bucketclient/lib/RESTClient.js:453:40)
+     at ClientRequest.emit (node:events:519:28)
+     at ClientRequest.emit (node:domain:489:12)
+     at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:772:27)
+     at HTTPParser.parserOnHeadersComplete (node:_http_common:122:17)
+     at Socket.socketOnData (node:_http_client:614:22)
+     at Socket.emit (node:events:519:28)
+     at Socket.emit (node:domain:489:12)
+     at addChunk (node:internal/streams/readable:561:12)
+     at readableAddChunkPushByteMode (node:internal/streams/readable:512:3)
+     at Readable.push (node:internal/streams/readable:392:5)
+     at TCP.onStreamRead (node:internal/stream_base_commons:189:23) {
+   BadRequest: true,
+   isExpected: true
+ }
- null
should fail if version id is invalid::PUT object with x-scal-s3-version-id header With default signature error handling validation (without cold storage location) should fail if version id is invalid
Stack Traces | 0.02s run time
Expected success got error {"BadRequest":true,"isExpected":true}
+ actual - expected

+ ArsenalError: BadRequest
+     at Object.get (.../lib/errors/index.js:167:31)
+     at RESTClient.endRespond (.../bucketclient/lib/RESTClient.js:329:27)
+     at ClientRequest.<anonymous> (.../bucketclient/lib/RESTClient.js:453:40)
+     at ClientRequest.emit (node:events:519:28)
+     at ClientRequest.emit (node:domain:489:12)
+     at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:772:27)
+     at HTTPParser.parserOnHeadersComplete (node:_http_common:122:17)
+     at Socket.socketOnData (node:_http_client:614:22)
+     at Socket.emit (node:events:519:28)
+     at Socket.emit (node:domain:489:12)
+     at addChunk (node:internal/streams/readable:561:12)
+     at readableAddChunkPushByteMode (node:internal/streams/readable:512:3)
+     at Readable.push (node:internal/streams/readable:392:5)
+     at TCP.onStreamRead (node:internal/stream_base_commons:189:23) {
+   BadRequest: true,
+   isExpected: true
+ }
- null
"before each" hook for "should return the rate limit config"::Test get bucket rate limit "before each" hook for "should return the rate limit config"
Stack Traces | 0.309s run time
Inaccessible host: `getratelimitestbucket.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.
"before each" hook for "should delete the bucket rate limit config"::Test delete bucket rate limit "before each" hook for "should delete the bucket rate limit config"
Stack Traces | 0.355s run time
Inaccessible host: `deleteratelimitestbucket.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.
"before each" hook for "should set the rate limit config"::Test put bucket rate limit "before each" hook for "should set the rate limit config"
Stack Traces | 0.494s run time
Inaccessible host: `putratelimitestbucket.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.
"after each" hook for "should set the rate limit config"::Test put bucket rate limit "after each" hook for "should set the rate limit config"
Stack Traces | 0.507s run time
Inaccessible host: `putratelimitestbucket.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.
"after each" hook for "should delete the bucket rate limit config"::Test delete bucket rate limit "after each" hook for "should delete the bucket rate limit config"
Stack Traces | 0.539s run time
Inaccessible host: `deleteratelimitestbucket.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.
"after each" hook for "should return the rate limit config"::Test get bucket rate limit "after each" hook for "should return the rate limit config"
Stack Traces | 0.619s run time
Inaccessible host: `getratelimitestbucket.127.0.0.1' at port `undefined'. This service may not be available in the `us-east-1' region.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-724-legacy-related-functional-tests branch 3 times, most recently from 5b3a4ed to 67b5ecb Compare October 28, 2025 14:37
@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-724-service-get-related-functional-tests branch 3 times, most recently from 72dd6ed to cd35cca Compare October 28, 2025 15:59
@benzekrimaha benzekrimaha marked this pull request as ready for review October 28, 2025 16:00
@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-724-legacy-related-functional-tests branch from 67b5ecb to e05e03c Compare December 4, 2025 06:38
This commit updates functional tests for 'get' service to ensure compatibility
with recent changes in the aws sdk.
Issue: CLDSRV-724
@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-724-service-get-related-functional-tests branch from cd35cca to 0fec989 Compare December 4, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants